fix(web, SafeAreaView): replace default export with named export#3956
Open
roryabraham wants to merge 1 commit intosoftware-mansion:mainfrom
Open
fix(web, SafeAreaView): replace default export with named export#3956roryabraham wants to merge 1 commit intosoftware-mansion:mainfrom
roryabraham wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
kkafar
reviewed
Apr 29, 2026
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Hey, thanks for catching this & PR.
If this is an regression introduced in beta version, we can get rid of the default export entirely.
roryabraham
force-pushed
the
fix/safe-area-view-web-named-export
branch
from
cd8e4f3 to
39e08c4
Compare
The safe-area/index.ts re-exports SafeAreaView as a named export:
export { SafeAreaView } from './SafeAreaView';
For web builds, webpack resolves './SafeAreaView' to './SafeAreaView.web.tsx',
which only had a default export, causing a ModuleDependencyWarning at build
time since the named export 'SafeAreaView' could not be found.
The native variant (SafeAreaView.tsx) only has a named export, and the
package's public surface only re-exports as named, so align the web variant
to match by replacing the default export with a named export.
Co-authored-by: Cursor <[email protected]>
roryabraham
force-pushed
the
fix/safe-area-view-web-named-export
branch
from
39e08c4 to
c316bb5
Compare
roryabraham
changed the title
Author
|
updated |
roryabraham
added a commit
to Expensify/App
that referenced
this pull request
May 1, 2026
Aligns with the updated approach in the upstream PR (software-mansion/react-native-screens#3956): the native variant has only ever had a named export, and the package's public surface only re-exports as named, so dropping the default on web brings everything in line. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
safe-area/index.tsre-exportsSafeAreaViewas a named export:For web builds, webpack resolves
'./SafeAreaView'to'./SafeAreaView.web.tsx', which only had a default export:This causes a
ModuleDependencyWarningat build time:This also affects
ScreenStackItem.tsx, which does:For web builds this resolves to the
.webvariant, again hitting the same missing named export.Fix
Replace the default export with a named export in
SafeAreaView.web.tsxto match the native variant (SafeAreaView.tsx), which only has a named export, and the package's public surface (safe-area/index.ts), which only re-exports as named.Test plan
Related
Found while upgrading `react-native-screens` to `4.25.0-beta.1` in Expensify/App#89199.